Features/error boundary #6
Conversation
| const ErrorChild = <div className='custom-class'>{ErrorText}</div> | ||
|
|
||
| describe(`ErrorBoundary component test`, () => { | ||
| it('should component rendered properly with status [false]', () => { |
There was a problem hiding this comment.
Rename: should render with status [false]
There was a problem hiding this comment.
I will change it after merge because there is more file which needs to be changed
| const ErrorText = 'Error message' | ||
| const ErrorChild = <div className='custom-class'>{ErrorText}</div> | ||
|
|
||
| describe(`ErrorBoundary component test`, () => { |
There was a problem hiding this comment.
Rename: Component:ErrorBoundary. Then we can use the same pattern with other tests, like:
Service:AuthService
Utilities:Validation
There was a problem hiding this comment.
I will change it after merge because there is more file which needs to be changed
| <h1>{ErrorText}</h1> | ||
| </ErrorBoundary>, | ||
| ) | ||
| expect(rendered).toBeDefined |
There was a problem hiding this comment.
You can try to find a h1 element to make the test a bit more accurate.
For example:
const { container } = render(
<ErrorBoundary showError={true}>
<h1>{ErrorText}</h1>
</ErrorBoundary>,
)
// Find by selector:
const h1Element = container.querySelector('h1')
expect(h1Element).toBeTruthy()
// ...or find by text:
const h1Element = container.getByText(ErrorText)
expect(h1Element).toBeTruthy()
There was a problem hiding this comment.
I will change it after merge because there is more file which needs to be changed
| import { render } from '@testing-library/react' | ||
| import { ErrorBoundary } from '../../components/UI' | ||
|
|
||
| const ErrorText = 'Error message' |
There was a problem hiding this comment.
The capitalized names should be used with components, containers, services or models names.
For variables, use: errorText and errorChild.
The snake case, use with configurable variables, ie. API_KEY=xxxx
There was a problem hiding this comment.
I will change it after merge because there is more file which needs to be changed
No description provided.